Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Thinking in Redux category and move some pages in it #3889

Merged
merged 3 commits into from
Sep 27, 2020

Conversation

sbaudray
Copy link
Contributor

@sbaudray sbaudray commented Sep 24, 2020


name: 📖 Thinking in Redux
about: Adding a category and moving some pages to it

PR Type

Does this PR add a new page, or update an existing page?

It moves some pages to a new category

Checklist

What docs page is being added or updated?

  • Section: Added Thinking in Redux
  • Page:
    • introduction/motivation -> thinking-in-redux/motivation
    • introduction/three-principles -> thinking-in-redux/three-principles
    • introduction-prior-art -> thinking-in-redux/prior-art

For Adding New Content

What kind of content category is this page (tutorial, how-to, explanation, reference)?

Who is the intended target audience?

What knowledge are we assuming they have?

What are the intended results or takeaways from reading this page?

What is the most critical info they should learn?

For Updating Existing Content

What updates should be made to the page?

Do these updates change any of the assumptions or target audience? If so, how do they change?

@netlify
Copy link

netlify bot commented Sep 24, 2020

Deploy preview for redux-docs ready!

Built with commit 53888bf

https://deploy-preview-3889--redux-docs.netlify.app

@sbaudray sbaudray changed the title Create Thinking in Redux category and move some items in it Create Thinking in Redux category and move some pages in it Sep 24, 2020
@@ -65,11 +65,11 @@

# Old old Gitbook links?
/docs/introduction/CoreConcepts.html /introduction/core-concepts
Copy link
Contributor

@markerikson markerikson Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ These are the very old legacy Gitbook links. We do need to update these, but we also need to add new redirects from the current URLs as well.

Can you start a new comment-block-ish section somewhere labeled "2020 site reorganization" or soemthing along those lines, and add new redirect entries there from /introduction/ to /thinking-in-redux/ (or whatever we finally settle on) for these pages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be better now

@markerikson
Copy link
Contributor

Hey, thanks for filing this!

Got a couple items I'd like to discuss around intended organization before this is ready.

First, the other relevant PR here is #3600 , which talks about adding an "Understanding Redux" section that would have categories inside it like "Thinking in Redux" and "History and Design".

Second, given that, I'd like to see this new "Thinking in Redux" category as a sub-category.

Third, I'm not yet 100% sure I want to name the parent category "Understanding Redux", but I'm not immediately sure what a better option is. Suggestions?

@markerikson
Copy link
Contributor

Having thought about it further, I'm leaning towards:

  • New parent category, "Understanding Redux", at /understanding/
    • New child category, "Thinking in Redux", at /understanding/thinking-in-redux/
      • Motivation
      • Three Principles
    • New child category, "History and Design"
      • Prior Art

@markerikson
Copy link
Contributor

Awright, this looks pretty good. Confirmed the redirect for the "Motivation" page works correctly. Let's get this in.

@markerikson markerikson merged commit 31ce42b into reduxjs:master Sep 27, 2020
@markerikson
Copy link
Contributor

Hah. And of course, as soon as I hit the "Merge" button, I remembered that I wasn't 100% sure on having the "Understanding Redux" category be right below the "Introduction".

@sbaudray : Tell you what. Can you create a second PR that:

  • Moves the "Understanding" category to be after "Recipes" (ie, 4th in the sidebar list)
  • Moves the "Glossary" page from the "Other" category to "Understanding > Thinking in Redux"
  • Moves the "Troubleshooting" page from the "Other" category to "Recipes"
  • Removes the "Other" category entirely

From there, we can think about how to reorganize the "Introduction" and "Recipes" categories further.

webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants