-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Thinking in Redux category and move some pages in it #3889
Conversation
Deploy preview for redux-docs ready! Built with commit 53888bf |
@@ -65,11 +65,11 @@ | |||
|
|||
# Old old Gitbook links? | |||
/docs/introduction/CoreConcepts.html /introduction/core-concepts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ These are the very old legacy Gitbook links. We do need to update these, but we also need to add new redirects from the current URLs as well.
Can you start a new comment-block-ish section somewhere labeled "2020 site reorganization" or soemthing along those lines, and add new redirect entries there from /introduction/
to /thinking-in-redux/
(or whatever we finally settle on) for these pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be better now
Hey, thanks for filing this! Got a couple items I'd like to discuss around intended organization before this is ready. First, the other relevant PR here is #3600 , which talks about adding an "Understanding Redux" section that would have categories inside it like "Thinking in Redux" and "History and Design". Second, given that, I'd like to see this new "Thinking in Redux" category as a sub-category. Third, I'm not yet 100% sure I want to name the parent category "Understanding Redux", but I'm not immediately sure what a better option is. Suggestions? |
Having thought about it further, I'm leaning towards:
|
Awright, this looks pretty good. Confirmed the redirect for the "Motivation" page works correctly. Let's get this in. |
Hah. And of course, as soon as I hit the "Merge" button, I remembered that I wasn't 100% sure on having the "Understanding Redux" category be right below the "Introduction". @sbaudray : Tell you what. Can you create a second PR that:
From there, we can think about how to reorganize the "Introduction" and "Recipes" categories further. |
name: 📖 Thinking in Redux
about: Adding a category and moving some pages to it
PR Type
Does this PR add a new page, or update an existing page?
It moves some pages to a new category
Checklist
What docs page is being added or updated?
For Adding New Content
What kind of content category is this page (tutorial, how-to, explanation, reference)?
Who is the intended target audience?
What knowledge are we assuming they have?
What are the intended results or takeaways from reading this page?
What is the most critical info they should learn?
For Updating Existing Content
What updates should be made to the page?
Do these updates change any of the assumptions or target audience? If so, how do they change?