add example to reproduce defect of serializeQueryArgs with skipToken #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 586144b:
|
Themezv
commented
Nov 12, 2024
| @@ -125,6 +125,12 @@ const api = createApi({ | |||
| return true | |||
| }, | |||
| }), | |||
| queryWithDeepArg: build.query<string, { param: {nested: string} }>({ | |||
| query: ({param: {nested}}) => nested, | |||
| serializeQueryArgs: ({queryArgs}) => { | |||
There was a problem hiding this comment.
Here queryArgs have { param: { nested: string } } type. But called with skip token.
So queryArgs.param is undefined and then queryArgs.param.nested throws Cannot read property of undefined
Themezv
force-pushed
the
reproduce-serializeQueryArgs-skipToken
branch
from
9384f72
to
586144b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that reproduce the defect described in #3151