Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid auto-selecting instance in iFrames #1692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexandcote
Copy link

@alexandcote alexandcote commented Jun 21, 2024

Note: First time contributing to this project, open to feedback

Avoid auto-selecting the outer frame instance when redux exists in iFrame embedded on the page.

Fix: #1000

iFrame has a different tabID than the main frame. The connections are therefore not grouped properly.

Example:

{
  "connections": {
    "<tabId>" ["<firstConnectionID>"],
    "<iFrameTabId>": ["<secondConnectionID>"]
  }
}

Should we group those connections under the same key?
The fix is working but I'm unsure if it's the right solution to the problem.

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: d03eb59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
remotedev-redux-devtools-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Avoid auto selecting the outter frame instance when redux exist in
iFrame embedded on the page.
@alexandcote alexandcote force-pushed the alexandcote/fix-auto-select-iframe branch from cde8dbd to d03eb59 Compare June 21, 2024 20:45
@alexandcote alexandcote marked this pull request as ready for review June 21, 2024 20:46
@alexandcote
Copy link
Author

Hello @Methuselah96, sorry to ping you directly. I would love to finally fix this issue. Let me know if you would like me to use a different approach or tweak anything.

Thanks for you time

@Methuselah96
Copy link
Member

Hello @alexandcote, sorry for the lack of response so far. I've been digging into the code that controls auto-selection since some of it is related to upgrading to Manifest V3. As part of that investigation, I believe I've found a fix for this bug and I expect it will be included in the next release, which I hope to put out in the next few weeks.

Sorry it has taken so long to get to this, but I hope this will be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance auto-switches undesirably
2 participants