Avoid auto-selecting instance in iFrames #1692
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: First time contributing to this project, open to feedback
Avoid auto-selecting the outer frame instance when redux exists in iFrame embedded on the page.
Fix: #1000
iFrame has a different tabID than the main frame. The connections are therefore not grouped properly.
Example:
Should we group those connections under the same key?
The fix is working but I'm unsure if it's the right solution to the problem.