feat: Add metadata and links to matched postings / transactions #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm unsure of the status of this decade old issue (https://groups.google.com/g/beancount/c/MU6KozsmqGQ/m/TspjVxx-ZYIJ). This commit adds a config that adds metadata to matched postings such that they can be "linked" to one another. Alternatives would be using beancount's native links; however, I know in my use case at least I will have transactions with multiple matches (e.g., pay stubs with balances going to: multiple bank accounts, HSA, 401k, etc.). Thus, placing the match metadata at the transaction level is less clear. There is probably some performance hit when querying for matches on a posting level; but I feel that is negligible compared to the improvement in clarity. The use of random IDs might not be preferred, but I didn't want to try and format some human readable string. All I really care about is being able to pair transactions, not describe the match.
Forgot to leverage the config, and disable by default adding a match ID. Added a test to cover the default case, in which no match IDs are added.
Should not have committed this.
Added some missing whitespace.
Type tests in effective_date
|
Hi there, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the code in #25 and adds a config option to add transaction-level links to the transactions of paired postings. It also allows for changing the metadata key or link prefix.
Please let me know if I'm doing something silly, I'm pretty new to using beancount.