[CORE-16830] rptest: extend start_timeout in timely_shutdown_test#31051
Open
WillemKauf wants to merge 1 commit into
Open
[CORE-16830] rptest: extend start_timeout in timely_shutdown_test#31051WillemKauf wants to merge 1 commit into
rptest: extend start_timeout in timely_shutdown_test#31051WillemKauf wants to merge 1 commit into
Conversation
In this test, the background failure injector repeatedly isolates a random non-leader node, which can strip the 3-node controller of quorum while the restarted node is trying to rejoin. Give the restarting node some extra timeout slack to avoid test flakes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakes in timely_shutdown_test by giving a restarting node more time to come back up in the presence of background network isolation faults that can temporarily remove controller quorum.
Changes:
- Adds an explanatory comment about why additional restart slack is needed under the finjector.
- Increases
restart_nodes(..., start_timeout=90)for the leader restart loop.
Comment on lines
+115
to
+118
| # The background failure injector repeatedly isolates a random | ||
| # non-leader node, which can strip the 3-node controller of | ||
| # quorum while the restarted node is trying to rejoin. Give the | ||
| # restarting node some extra timeout slack. |
Collaborator
CI test resultstest results on build#86881
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this test, the background failure injector repeatedly isolates a random non-leader node, which can strip the 3-node controller of quorum while the restarted node is trying to rejoin.
Give the restarting node some extra timeout slack to avoid test flakes.
Backports Required
Release Notes