kafka/tests: fix flaky unlicensed enterprise tests#29740
Draft
nguyen-andrew wants to merge 1 commit intoredpanda-data:devfrom
Draft
kafka/tests: fix flaky unlicensed enterprise tests#29740nguyen-andrew wants to merge 1 commit intoredpanda-data:devfrom
nguyen-andrew wants to merge 1 commit intoredpanda-data:devfrom
Conversation
Wait for async trial license init before revoking, and use update_cluster_config to propagate config to all shards.
6996a93 to
ec23951
Compare
Member
Author
|
/rp-unit-test |
Collaborator
|
Invalid arch arm64 . Must be one of amd64,arm64. |
Member
Author
|
/rp-unit-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unlicensed_reject_defaultsandunlicensed_rejectedtests increate_topics_test.ccare flaky in CI. Two issues cause the tests to intermittently pass when they should enforce enterprise license checks:revoke_license()and the async trial license initmetrics_reporter::try_initialize_cluster_info(). If the init completed before revoke,should_sanction()is permissive.lconf().cloud_storage_enabled.set_value(true)only sets the config shard 0. If the Kafka handler runs on another shard,is_restricted()returns false.This adds a
wait_for_license_init()helper that waits for the async trial license to be initialized before revoking, and switches config mutations toupdate_cluster_config()to propagate to all shards.Fixes CORE-15319
Backports Required
Release Notes