Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model/x: Fix typo in legacy offset_options envelope template #20828

Merged
merged 1 commit into from
Jul 5, 2024
Merged

model/x: Fix typo in legacy offset_options envelope template #20828

merged 1 commit into from
Jul 5, 2024

Commits on Jul 3, 2024

  1. model/x: Fix typo in legacy offset_options envelope template 

    s/transform_offset_options/legacy_transform_offset_options/

Also adds unit tests to try prove out the theory of selectively
writing out older versions of the serde::variant. Works as expected.

Also worth noting that this works regardless of the serde::envelope
CRTP param fixed by this diff...perhaps that's due to the narrow
scope of the legacy struct - only ever being written out explicitly
in transform_metadata::serde_write.

Signed-off-by: Oren Leiman <[email protected]>
    @oleiman
    oleiman committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3ff2249 View commit details
    Browse the repository at this point in the history