Fixup some headers #20779
Merged
Fixup some headers #20779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <[email protected]>
src/v/config depends on quite a few things in
src/v/model/{fundamental,metadata} unfortunately. so having fips_enable
from_config helper in model/fundamental.h creates a circular dependency.
the fix is to split out this one function into a separate header.
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
Includes of serde/serde.h bring in a lot of bits. Narrowing the scope of serde includes by using serde/rw/*.h files means that downstream users may be missing a lot of required includes. Signed-off-by: Noah Watkins <[email protected]>
michael-redpanda
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes