rpk: allow names to be URIs in the reference flag when creating a schema. #20757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a schema. jsonschema will introduce URIs as valid reference names.
r-vasquez
requested review from
twmb,
gene-redpanda and
Deflaimun
as code owners
r-vasquez
commented
Jun 28, 2024
| // characters to capture optional ports in the authority and the path. | ||
| // 2. Captures any character except ':' (subject). | ||
| // 3. Captures any character except ':' (version). | ||
| var referenceRegex = regexp.MustCompile(`^([a-zA-Z]+://[^:]+(?::\d+)?(?:/[^:]+)*|[^:]+):([^:]+):([^:]+)$`) |
There was a problem hiding this comment.
I could validate here that the third capturing group is a digit, but the error from L174 (strconv.Atoi) is better for the user to understand where the problem is.
|
Should we update docs or is this just an under the hood improvement? |
The latter |
twmb
approved these changes
Jul 1, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonschema will introduce URIs as valid reference names.
Backports Required
Release Notes