[rptest] Azure CDT bringup #20749
[rptest] Azure CDT bringup #20749
Conversation
|
|
- replaces several instances of deprecated Cloud API usage with new Public API (because the old endpoints don't return Azure resources) - successfully installs BYOC Azure agent - allow override headers on POST requests for rpcloud_client - workaround for /snap/bin not showing up in $PATH (making `az` CLI not show up as an available command) - Azure support for config_profile_verify test
| if self._provider == 'azure': | ||
| # for azure, we manually override the path here to ensure | ||
| # that azure-cli installed as a snap gets found (workaround) | ||
| p = ['env', 'PATH=/usr/local/bin:/usr/bin:/bin:/snap/bin'] |
There was a problem hiding this comment.
should this append PATH at the end? just to ensure that other binaries that might be implicitly invoked (if any) can be found
There was a problem hiding this comment.
Short answer: no need!
Longer answer: I don't know if environment variable expansion works with the options we use, so I assumed it wouldn't and grabbed the default full $PATH (including /snap/bin) from an interactive shell, and then I removed /usr/games and /usr/local/games after confirming that both were completely empty on the agent VM's ubuntu install. So adding $PATH will only result in duplicating existing paths and adding empty directories to the search index.
|
what I was trying to mention during our sync today: to ensure that these changes don't break HTT tests on other cloud providers, given that these are not exercised at PR time, some manual jobs can be triggered (pointing to this branch) so that they are executed. |
Bug fixes to tests and test infrastructure for running CDT on Azure. (Note: Currently includes commit from #18827, will rebase after that gets merged.)
Backports Required
Release Notes
Improvements
azCLI not show up as an available command)