[v24.1.x] Do not set transaction timeout in tests that do not need it #20748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of our transactions tests were build based with the same code which often were copy pasted. The test were setting the default transaction timeout to 10 seconds as they might have been based on the test that validated the transactions expiration. Updated the tests to make sure that the timeout is set in the test that need it. The timeout made some tests to fail intermittently. Fixes: redpanda-data#18184 Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 797ac33)
|
/ci-repeat 1 |
1 similar comment
|
/ci-repeat 1 |
piyushredpanda
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #20743
Fixes: #20746,