tests/node_ops: avoid interference betwen failure injections and ops #20309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/dt |
bashtanov
force-pushed
the
test-node-ops-failures-no-interfere
branch
from
b8c0188
to
18b2a4e
Compare
|
/dt |
bashtanov
force-pushed
the
test-node-ops-failures-no-interfere
branch
from
18b2a4e
to
3d28155
Compare
|
/dt |
They can already be separated with a lock, but it's not sufficient. We need certain delay between them.
bashtanov
force-pushed
the
test-node-ops-failures-no-interfere
branch
from
3d28155
to
308667f
Compare
|
/dt |
1 similar comment
|
/dt |
bharathv
reviewed
Jun 28, 2024
| @@ -330,6 +332,7 @@ def stop_node(self, idx): | |||
| with self.lock: | |||
| self.redpanda.remove_from_started_nodes(node) | |||
| self.redpanda.stop_node(node) | |||
| time.sleep(self.wait_after_stop) | |||
There was a problem hiding this comment.
how exactly this fixes the issue? The test failure is a idempotency violation, I thought that would be a code bug in most cases.
There was a problem hiding this comment.
The test uses both random failures and node decommissions. The problem was reproduced in the following way:
- node 2 was the leader, node 3 was mostly up to date with it, and node 4 was behind
- node 2 was restarted, and very shortly after it node 3 got down
- node 4 became a candidate and node 2 voted for it because when 2 restarted it could not recover up to the
majority_replicated_indexpoint, but rather only till some point below -- is it normal? - so some raft data was lost
|
i agree with Bharath that the solution from that PR doesn't fixe the issue mentioned in cover letter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can already be separated with a lock, but it's not sufficient. We need certain delay between them.
Fixes #18272
Backports Required
Release Notes