Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bazel foundation #19946

Draft
wants to merge 98 commits into
base: dev
Choose a base branch
from
Draft

build: bazel foundation #19946

wants to merge 98 commits into from

Conversation

dotnwat
Copy link
Member

@dotnwat dotnwat commented Jun 21, 2024 •
edited
Loading

Bazel build foundation.

https://redpandadata.atlassian.net/wiki/x/4wCZKg

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@dotnwat
bytes: reference header in current directory
7eebf73 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add third party dependencies
281b8c9 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: build wrapper
9895d33 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add baes library bazel build
39d3d9a 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add ssx library bazel build
61a0fe1 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add strings library bazel build
65ffd83 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add bytes library bazel build
80802ae 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add container library bazel build
e5aa44f 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils library bazel build
06ff960 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add crypto library bazel build
b90e0ca 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add random library bazel build
2b47fbd 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add serde library bazel build
b8d3ed2 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add test_utils library bazel build
e8efde5 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: update seastar and add config options
6826627 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add missing hwloc depdendency
e2fcf0a 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: use label conditions
be287e1 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: use inherited c++ standard setting
e58bd47 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: clarify seastar build comments
f9319a1 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: make strings library fine grained
82e7954 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add no-seastar boost test macro
4e96dcc 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add strings library tests
bbfde7d 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add crypto tests
9a1f8e6 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: make random library more fine grained
b52e2a7 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add random library tests
169f910 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: allow defines to pass through for test macro
ddd4cbd 
Useful for passing in BOOST_TEST_MODULE=foo to add a main().

Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add tests to utils library
cc035b8 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add base outcome test
01abe7a 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel
0bbd40e
@dotnwat
bazel: use a better name for seastar numactl option
075f5eb 
The config option `--@seastar//:numa=True` didn't read very intuitively,
so changed it to `numactl`.

Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add ssx tests
1fcd770 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add json library
dbc06de 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel
7cefc24
@dotnwat
bazel: add fix variant of buildifier command
83c1c21 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils:uuid library
c2db0a8 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add reflection utility libraries
69110a4 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add additional serde tag_invoke helpers
a79fb21 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils::uuid test
8912807 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils:xid library and test
97a9e9a 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
Merge remote-tracking branch 'origin/dev' into HEAD
5dcaaf5
@dotnwat
bazel: ignore build directories
a9b8a88 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add missing header to seastar build
29982fe 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: allow local_defines pass through to library macro
ec7a722 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils:static_deleter_fn library
1f5145b 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils:functional library
956faf7 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add ssx:future-util library
f5a2039 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add reflection:adl library
8958c57 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add several serde rw tag_invoke libraries
f1c0574 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add utils:to_string library
0e3c42d 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add model library
4505f93 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add compression library
d5e38a1 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
Merge remote-tracking branch 'origin/dev' into bazel
20ec04c
@dotnwat
bazel: enable layering_check by default
00e29d5 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
Merge pull request #17 from dotnwat/layering-check
8b74a72 
bazel: enable layering_check by default
@dotnwat
bazel: remove non-library code from avro
f862f7b 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add missing avro dependencies
b813371 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add missing utils:uuid dependency
e6d916a 
Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: build xxhash explicitly
8484270 
The version of xxhash provided by bzlmod requires -iquoted includes
which prevents redpanda's use of brackets: <xxhash.h>. this isn't
inherently a problem, we probably should use quoted includes. but in the
interim state where both cmake and bazel are in use we need some
flexibility. so we build xxhash manually so we can control this.

Signed-off-by: Noah Watkins <[email protected]>
@dotnwat
bazel: add missing system dependencies
7985abd 
Signed-off-by: Noah Watkins <[email protected]>
rockwotj
rockwotj reviewed Jul 1, 2024
View reviewed changes
bazel/install-deps.sh
git
cargo
rustc
bison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to build this on my freshly installed ubuntu noble I also needed xutils-dev for libpciaccess

rockwotj
rockwotj reviewed Jul 1, 2024
View reviewed changes
bazel/internal.bzl
scripts in the `bazel/` directory.
"""

def redpanda_copts():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the existing copts too:

redpanda/cmake/v_library.cmake

Line 5 in 6094a4e

set(V_DEFAULT_COPTS -Wall -Wextra -Werror -Wno-missing-field-initializers -Wimplicit-fallthrough)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockwotj rockwotj rockwotj left review comments

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda michael-redpanda will be requested when the pull request is marked ready for review michael-redpanda is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/redpanda area/wasm WASM Data Transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotnwat @emaxerrno @rockwotj