[v23.2.x] cloud: Add config options to trigger cache trim #19629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcipar
force-pushed
the
backport-pr-18756-v23.2.x-768
branch
from
e71f512
to
c04370d
Compare
When the cloud storage cache is completely filled, puts to the cache are blocked. This prevents readers from progressing. In some clusters the trim operation can take a long time, up to hours. When this happens, readers will time out, generating errors. This commit adds two configuration options that control when the trim is triggered. By setting these lower than the caches maximum size, cloud storage can begin a trim operation before the cache is completely filled, allowing readers to progress as the trim is going on in the background. - cloud_storage_cache_trim_threshold_size - cloud_storage_cache_trim_threshold_objects When a put occurs, if the cache is over these limits it triggers a trim in the background. (cherry picked from commit 027632c)
jcipar
force-pushed
the
backport-pr-18756-v23.2.x-768
branch
from
9b241c6
to
167c443
Compare
andrwng
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18756
Backports Required