Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.2.x] admin: fix cache trim parameter order #18765

Merged
merged 3 commits into from
Jun 4, 2024
Merged

[v23.2.x] admin: fix cache trim parameter order #18765

merged 3 commits into from
Jun 4, 2024

Commits on Jun 3, 2024

  1. admin: fix cache trim parameter order 

    The arguments are reversed.

(cherry picked from commit 1d6f388)
    @andrwng
    andrwng committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    73d7a12 View commit details
    Browse the repository at this point in the history

  2. cloud_storage: log about manual trim 

    We don't expect these to be frequent by any means. It's useful to know
about the input parameters, e.g. in case there's a bug in running it.

(cherry picked from commit 3fd9135)
    @andrwng
    andrwng committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    25f30c8 View commit details
    Browse the repository at this point in the history

  3. admin: fix some incorrect stoi usages 

    CONFLICTS:
- uses [] instead of get_param

- get_integer_query_param() returns a uint64_t
- revision ids are int64_t

(cherry picked from commit a6fcac5)
    @andrwng
    andrwng committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    66251be View commit details
    Browse the repository at this point in the history