Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuring tuner values #81

Merged
merged 1 commit into from
Feb 26, 2024
Merged

allow configuring tuner values #81

merged 1 commit into from
Feb 26, 2024

Conversation

gene-redpanda
Copy link
Contributor

@gene-redpanda gene-redpanda commented Feb 26, 2024 •
edited
Loading

hcoyote
hcoyote approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@hcoyote hcoyote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

r-vasquez
r-vasquez approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few tuners that are not managed here, but they are not part of the production mode.

  • fstrim
  • transparent_hugepages
  • coredump

But these are needed in some special use cases and can be added later. (Or we can add them here with default(false)

@gene-redpanda gene-redpanda merged commit 6fc1f3f into main Feb 26, 2024
@gene-redpanda gene-redpanda deleted the enable-tuner-config branch March 7, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcoyote hcoyote hcoyote approved these changes

@r-vasquez r-vasquez r-vasquez approved these changes

@twmb twmb Awaiting requested review from twmb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gene-redpanda @hcoyote @r-vasquez