Skip to content

Conversation

@clee
Copy link
Contributor

@clee clee commented Dec 5, 2025

This should get us to a newer NPM version with support for trusted publishing.

@netlify
Copy link

netlify bot commented Dec 5, 2025

Deploy Preview for docs-extensions-and-macros ready!

Name Link
🔨 Latest commit 98d3e6c
🔍 Latest deploy log https://app.netlify.com/projects/docs-extensions-and-macros/deploys/6933209c49acb80008390291
😎 Deploy Preview https://deploy-preview-160--docs-extensions-and-macros.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

This PR updates the Node.js version used in the publish-to-npm GitHub Actions workflow from version 20 to version 22. The change affects a single configuration file with no modifications to workflow steps or logic. This is a straightforward runtime environment version bump for the npm package publishing process.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file modified with a straightforward version number change
  • No functional logic or workflow step changes
  • Minimal risk; version bump is isolated to Node.js runtime selection

Possibly related PRs

  • PR #158: Also modifies the publish-to-npm workflow file; implements OIDC authentication and updates action versions to address token security concerns tied to the same npm publishing pipeline

Suggested reviewers

  • andrewhsu
  • JakeSCahill

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'gha: bump node version' accurately describes the main change - updating Node.js version in a GitHub Actions workflow.
Description check ✅ Passed The description explains the purpose of the change (newer NPM version for trusted publishing support), which is directly related to the Node version bump.
Linked Issues check ✅ Passed The PR addresses DEVPROD-3689 by bumping Node.js to access a newer npm version that supports trusted publishing, required before 12/09 classic token revocation.
Out of Scope Changes check ✅ Passed All changes are within scope - only the Node.js version in the publish-to-npm workflow was updated to support the trusted publishing objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 195f3ae and 4a429fd.

📒 Files selected for processing (1)
  • .github/workflows/publish-to-npm.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: test-property-extractor (3.11)
  • GitHub Check: test-property-extractor (3.9)
  • GitHub Check: Redirect rules - docs-extensions-and-macros
  • GitHub Check: Header rules - docs-extensions-and-macros
  • GitHub Check: Pages changed - docs-extensions-and-macros

@clee clee force-pushed the DEVPROD-3689-bump-node-version branch from 4a429fd to 98d3e6c Compare December 5, 2025 18:12
@JakeSCahill JakeSCahill merged commit 0279df9 into main Dec 5, 2025
18 of 19 checks passed
@JakeSCahill JakeSCahill deleted the DEVPROD-3689-bump-node-version branch December 5, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants