frontend: fix hooks & purity react-doctor rules#2293
Closed
malinskibeniamin wants to merge 3 commits intoreact-doctor/1-infrastructurefrom
Closed
frontend: fix hooks & purity react-doctor rules#2293malinskibeniamin wants to merge 3 commits intoreact-doctor/1-infrastructurefrom
malinskibeniamin wants to merge 3 commits intoreact-doctor/1-infrastructurefrom
Conversation
- Add 'use no memo' directives to 60 components using incompatible libraries (TanStack Table, react-hook-form, Zustand stores) - Add React Compiler source filter in rsbuild.config.ts - Add useApiStoreHook typed wrapper for Zustand store selectors - Fix type errors in header, sidebar, and require-auth components Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Enable and fix 7 react-doctor rules for hooks, refs, purity, and component quality: - hooks: fix hook ordering and conditional hook calls - refs: fix ref access patterns (no writes in render) - purity: remove side effects from render path - immutability: replace direct mutations with immutable updates - todo: add useCallback/useMemo where flagged - error-boundaries: enable error boundary patterns - static-components: extract static JSX outside render Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Base automatically changed from
react-doctor/2-compiler-compat
to
react-doctor/1-infrastructure
March 11, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable and fix 7 react-doctor rules for hooks quality and component purity.
React Doctor Score: 100/100
PR 5 of 6 in the react-doctor incremental rollout. Depends on #2289.
Test Plan
bun run type:checkpassesbun run doctorpasses with 100/100🤖 Generated with Claude Code