Skip to content

mysqlcdc: replace deprecated 'SHOW MASTER STATUS' for 8.4+ #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephwoodward merged 1 commit into from
Mar 12, 2026
Merged

mysqlcdc: replace deprecated 'SHOW MASTER STATUS' for 8.4+ #4094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions internal/impl/mysql/snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,15 @@ func (s *Snapshot) getCurrentBinlogPosition(ctx context.Context) (position, erro
executedGtidSet any
)

row := s.snapshotConn.QueryRowContext(ctx, "SHOW MASTER STATUS")
if err := row.Scan(&file, &offset, &binlogDoDB, &binlogIgnoreDB, &executedGtidSet); err != nil {
return position{}, err
scanRow := func(row *sql.Row) error {
return row.Scan(&file, &offset, &binlogDoDB, &binlogIgnoreDB, &executedGtidSet)
}

// "SHOW BINARY LOG STATUS" replaces "SHOW MASTER STATUS" IN MySQL 8.4+
if err := scanRow(s.snapshotConn.QueryRowContext(ctx, "SHOW BINARY LOG STATUS")); err != nil {
if err = scanRow(s.snapshotConn.QueryRowContext(ctx, "SHOW MASTER STATUS")); err != nil {
return position{}, err
}
}

return position{
Expand Down
Loading