Skip to content

redis_streams: add interpolation support for entry ID#4052

Open
twmb wants to merge 1 commit intomainfrom
1152
Open

redis_streams: add interpolation support for entry ID#4052
twmb wants to merge 1 commit intomainfrom
1152

Conversation

@twmb
Copy link
Contributor

@twmb twmb commented Mar 2, 2026

Allow users to specify a custom entry ID for the redis_streams output using Bloblang interpolation, instead of always auto-generating with "*". This enables replaying messages in upstream order.

Closes #1242

@claude
Copy link

claude bot commented Mar 2, 2026

Claude finished @twmb's task in 1m 51s —— View job


  • Fetch PR data and read agent guidelines
  • Validate commit policy
  • Review code changes
  • Post summary

Commits
LGTM

Review
Clean addition of an interpolated id field to the redis_streams output, preserving backwards compatibility with the "*" default. Config spec, field constant, struct field, parsing, and both WriteBatch code paths (single and batched) are all consistent with project patterns.

  1. t.Context() used inside t.Cleanup() in both test subtests (lines 142 and 174) — should be context.Background() since t.Context() is already canceled during cleanup.

Allow users to specify a custom entry ID for the redis_streams output
using Bloblang interpolation, instead of always auto-generating with "*".
This enables replaying messages in upstream order.

Closes #1242

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link

claude bot commented Mar 2, 2026

Claude finished @twmb's task in 1m 5s —— View job


  • Fetch PR data and read agent guidelines
  • Validate commit policy
  • Review code changes
  • Post summary

Commits
LGTM

Review
Clean addition of an interpolated id field to the redis_streams output, preserving backwards compatibility with the "*" default. The previous review's t.Context() concern in t.Cleanup() has been addressed — both cleanup calls now correctly use context.Background().

LGTM


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add interpolation support for Entry ID in Redis Streams

1 participant