Make broker connection retry interval configurable in kafka sarama input #2679
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and leave it up to the framework instead
…t instantly), now setting the interval
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sarama loses its connection with the broker, it retries to establish it.
By default, the interval for retrying is set to 250ms (see here).
What we occasionally observe is that when a kafka cluster instance restarts, there's a thundering herd of benthos consumers retrying the connection. If we make the interval configurable, we can improve this situation.
I'm also open to making a PR to make the whole sarama retry config configurable, made a draft PR for that here, but maybe that's overkill.