Skip to content

fix: make GHCR push non-fatal, split Docker Hub and GHCR builds #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redoracle merged 1 commit into from
Aug 10, 2026
Merged

fix: make GHCR push non-fatal, split Docker Hub and GHCR builds #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,21 @@ jobs:
# Login to Docker Hub
echo "${DOCKER_PASSWORD}" | docker login -u "${DOCKER_USER}" --password-stdin

# Login to GitHub Container Registry
echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin || true

# Build and push multi-platform image with version + latest tags
# Build and push to Docker Hub (primary)
docker buildx build . \
--platform linux/amd64,linux/arm64 \
-t docker.io/${DOCKER_USER}/dockersnap:latest \
-t docker.io/${DOCKER_USER}/dockersnap:${VERSION} \
--push

echo "Docker Hub image pushed for ${VERSION}"

# Push to GitHub Container Registry (secondary, non-fatal)
echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin 2>/dev/null || true
docker buildx build . \
--platform linux/amd64,linux/arm64 \
-t ghcr.io/${{ github.repository_owner }}/dockersnap:latest \
-t ghcr.io/${{ github.repository_owner }}/dockersnap:${VERSION} \
--push
--push 2>/dev/null || echo "Warning: GHCR push failed (non-fatal)"

echo "Docker image built and pushed for ${VERSION}"
echo "Docker image build complete for ${VERSION}"