Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Smarti widget: Provide "can not help"-information #213

Closed
mrsimpson opened this issue Feb 22, 2018 · 9 comments
Closed

Smarti widget: Provide "can not help"-information #213

mrsimpson opened this issue Feb 22, 2018 · 9 comments
Assignees
Milestone

Comments

@mrsimpson
Copy link
Collaborator

as per #200, queries are now always being built - but if there's no query to be executed (e. g. since no token could be extracted), there should be a meaningful information on the widget that Smarti cannot help at the moment

@westei
Copy link
Member

westei commented Mar 5, 2018

depends on #217

@mrsimpson mrsimpson added the bug label Mar 5, 2018
@mrsimpson mrsimpson added this to the v0.7.1 milestone Mar 5, 2018
@ruKurz
Copy link
Collaborator

ruKurz commented Mar 12, 2018

Isn't this a duplication of: #220 or the other way around?

@westei
Copy link
Member

westei commented Mar 19, 2018

if @mrsimpson agrees we can merge this into #220

@Peym4n
Copy link
Contributor

Peym4n commented Apr 5, 2018

See #220 (comment)

@Peym4n Peym4n closed this as completed Apr 5, 2018
@ghost ghost removed the in progress label Apr 5, 2018
@mrsimpson
Copy link
Collaborator Author

How does the i18n address this issue?

@mrsimpson mrsimpson reopened this Apr 5, 2018
@westei
Copy link
Member

westei commented Apr 6, 2018

If the widget does not have Tokens for a Query is shows the "can not help" message. Doing it on the server side is only part of the story. For sure one could mark a query as "incomplete" if no Tokens are available, but in the End the WIdget decides if tokens are assigned to a Query. So even if if Smarti things their are Tokens available the Widget might still not assign any Tokens (e.g. because the User removes a token). So the final decision is anyways by the widget so we need to have this logic anyways in the Widget.

@Peym4n
Copy link
Contributor

Peym4n commented Apr 6, 2018

@mrsimpson when I first sent that comment I mistakenly linked another irrelevant comment (i18n) but then I edited it. The linked comment describes what the solution to this issue is.
And as I believe that #220 is a duplicate of this issue I closed this one.

@westei
Copy link
Member

westei commented Apr 12, 2018

@mrsimpson can you check/update the state of this issue. Especially why have you moved it to the backlog? I am unsure how to proceed.

@mrsimpson
Copy link
Collaborator Author

I moved it back to the backlog since we effectively have no option to understand whether Smarti can actually help to facilitate the conversation or not.
I thought of having a property per query provider which allows the UI to react on it.
You commented this extensively in #226.
maybe we should close both of them and formulate a better story, also based on your ideas.
I take a step forward and close this one, at least in favor of #226

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants