Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Tempaltes and Queries need always be built #200

Closed
westei opened this issue Feb 9, 2018 · 3 comments
Closed

Tempaltes and Queries need always be built #200

westei opened this issue Feb 9, 2018 · 3 comments
Assignees
@westei @Peym4n
Labels
enhancement
Milestone
v0.7.0

Comments

@westei
Copy link
Member

westei commented Feb 9, 2018

The widget gets the sources ("Quellen") from the queries in the analysis response. Currently templates and queries might not be present if no fitting Tokens where extracted from the conversation.

In this case the Widget is missing information about available sources and can not use them even if the user manually creates Tokens in the User Interface.
@westei westei added this to the v0.7.0 milestone Feb 9, 2018
@westei westei self-assigned this Feb 9, 2018
@mrsimpson
Copy link
Collaborator

maybe, the query could be flagged so that a consumer knows it's lacking input in order to produce meaningful results.

@westei westei added in progress and removed ready labels Feb 12, 2018
westei added a commit that referenced this issue Feb 12, 2018
@westei
fixes for #200 and #201:
2445257 
* QueryBuilders are now always adding Query elements to the Template even if no Token is available
* The conversation search QueryBuilder now supports Terms (in addition to keywords)

Additional:

* The conversation search QueryBuilder has now an option to exclude the current conversation from Results (default: true)
@janrudolph
Copy link
Collaborator

Decision: Provide a meaningful information for the user that no sense could be made of the conversation and a call-to-action to enter search terms

westei added a commit that referenced this issue Feb 14, 2018
@westei
#200: acceptTemplate needs also to return true if the template does…
b7b545b 
… not have any assigned slots
@mrsimpson mrsimpson mentioned this issue Feb 22, 2018
Closed
@mrsimpson
Copy link
Collaborator

For the widget, I created #213.
However, there has to be some information on the API level that the state of Smarti "not being able to help" can be respected in the UI.

@westei is this information already part of the model?

@westei westei mentioned this issue Feb 26, 2018
Closed
@ja-fra ja-fra closed this as completed in 66acf7a Feb 28, 2018
@ghost ghost removed the in review label Feb 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@westei westei

@Peym4n Peym4n

Labels
enhancement
Projects
None yet
Milestone
v0.7.0
Development

No branches or pull requests
4 participants
@westei @Peym4n @janrudolph @mrsimpson