Skip to content

Fixing argument type hints for evalsha and similar commands. #3794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing argument type hints for evalsha and similar commands. #3794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions redis/commands/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5863,12 +5863,16 @@ class ScriptCommands(CommandsProtocol):
"""

def _eval(
self, command: str, script: str, numkeys: int, *keys_and_args: str
self,
command: str,
script: str,
numkeys: int,
*keys_and_args: Union[KeyT, EncodableT],
) -> Union[Awaitable[str], str]:
return self.execute_command(command, script, numkeys, *keys_and_args)

def eval(
self, script: str, numkeys: int, *keys_and_args: str
self, script: str, numkeys: int, *keys_and_args: Union[KeyT, EncodableT]
) -> Union[Awaitable[str], str]:
"""
Execute the Lua ``script``, specifying the ``numkeys`` the script
Expand All @@ -5883,7 +5887,7 @@ def eval(
return self._eval("EVAL", script, numkeys, *keys_and_args)

def eval_ro(
self, script: str, numkeys: int, *keys_and_args: str
self, script: str, numkeys: int, *keys_and_args: Union[KeyT, EncodableT]
) -> Union[Awaitable[str], str]:
"""
The read-only variant of the EVAL command
Expand All @@ -5897,12 +5901,16 @@ def eval_ro(
return self._eval("EVAL_RO", script, numkeys, *keys_and_args)

def _evalsha(
self, command: str, sha: str, numkeys: int, *keys_and_args: list
self,
command: str,
sha: str,
numkeys: int,
*keys_and_args: Union[KeyT, EncodableT],
) -> Union[Awaitable[str], str]:
return self.execute_command(command, sha, numkeys, *keys_and_args)

def evalsha(
self, sha: str, numkeys: int, *keys_and_args: str
self, sha: str, numkeys: int, *keys_and_args: Union[KeyT, EncodableT]
) -> Union[Awaitable[str], str]:
"""
Use the ``sha`` to execute a Lua script already registered via EVAL
Expand All @@ -5918,7 +5926,7 @@ def evalsha(
return self._evalsha("EVALSHA", sha, numkeys, *keys_and_args)

def evalsha_ro(
self, sha: str, numkeys: int, *keys_and_args: str
self, sha: str, numkeys: int, *keys_and_args: Union[KeyT, EncodableT]
) -> Union[Awaitable[str], str]:
"""
The read-only variant of the EVALSHA command
Expand Down