Test against unstable hiredis-py #3617
Conversation
The guard was required to prevent cluster tests on RESP3 with hiredis-py before 3.1.0
There was a problem hiding this comment.
Pull Request Overview
This PR introduces integration tests to verify functionality against the unstable version of hiredis-py.
- Adds a new GitHub Actions workflow (.github/workflows/hiredis-py-integration.yaml) to run integration tests with different Python and Redis versions.
- Enhances the run-tests action (.github/actions/run-tests/action.yml) by including a new input for the hiredis branch and adding steps to checkout and install the unstable version of hiredis-py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/hiredis-py-integration.yaml | New workflow to run hiredis-py integration tests. |
| .github/actions/run-tests/action.yml | Updated action inputs and installation steps for unstable hiredis-py. |
| @@ -40,8 +52,13 @@ runs: | |||
| pip uninstall -y redis # uninstall Redis package installed via redis-entraid | |||
| pip install -e .[jwt] # install the working copy | |||
| if [ "${{inputs.parser-backend}}" == "hiredis" ]; then | |||
| pip install "hiredis${{inputs.hiredis-version}}" | |||
| echo "PARSER_BACKEND=$(echo "${{inputs.parser-backend}}_${{inputs.hiredis-version}}" | sed 's/[^a-zA-Z0-9]/_/g')" >> $GITHUB_ENV | |||
| if [[ "${{inputs.hiredis-version}}" == "unstable" ]]; then | |||
There was a problem hiding this comment.
[nitpick] Consider using a consistent shell test syntax. Since other conditions in the file use '[ ... ]', using the same syntax across the file may improve maintainability, even if the current bash-specific syntax works correctly.
| if [[ "${{inputs.hiredis-version}}" == "unstable" ]]; then | |
| if [ "${{inputs.hiredis-version}}" = "unstable" ]; then |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
The suggestion is missing one "=" sign
|
@uglide how will the new workflow be triggered? Currently, I don't see it in the pipelines executed for the branch. Can you please provide some reference to another repo where similar workflow is used? |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.