Fix multi-shard explanation. #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for redis-doc pending review.Visit the deploys page to approve it
|
oranagra
approved these changes
Jul 20, 2023
docs/reference/command-tips.md
Outdated
| @@ -50,7 +50,7 @@ In cases where the client should adopt a behavior different than the default, th | |||
| This tip is in-use by commands that don't accept key name arguments. | |||
| The command operates atomically per shard. | |||
| - **multi_shard:** the client should execute the command on several shards. | |||
| The shards that execute the command are determined by the hash slots of its input key name arguments. | |||
| The client should split the inputs according to the hash slots of its input key name arguments. For example, the command `MSET {foo} baz {foo}1 baz1 bar vaz` should be split to `MSET {foo} baz {foo}1 baz1` and `MSET bar vaz`. If the keys are hashed to more than a single slot, the command must be split even if all the slots are managed by the same shard. | |||
There was a problem hiding this comment.
maybe an example with DEL will be easier to follow?
There was a problem hiding this comment.
I intentionally chose MSET, because it's slightly more complex than MGET / DEL. If you think that the phrasing and principle are clear enough that a less complex example would work, I'll switch to DEL.
There was a problem hiding this comment.
i think the principle is clear enough with DEL and MGET and it'll be easier to read.
it's right that the implementation in case of MSET is more complex, but that's something to worry about in implementation stage.
oranagra
approved these changes
Jul 23, 2023
zuiderkwast
approved these changes
Jan 5, 2024
|
I merged this now. Thanks! I have two other questions regarding the multi-shard request policy:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.