Update stars of redismodule-ratelimit + JSON formatting #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
approved these changes
Jun 15, 2021
| "stars": 0 | ||
| "stars": 19 |
There was a problem hiding this comment.
This matches the github stars of the project. Verified.
|
Would prefer to not merge this unless we plan on implementing a checker to validate the format of the various JSON files. |
|
@madolson Do you mean the whitespace changes or the number of stars? I guess it'd possible to check/automate both... |
|
@zuiderkwast yes and yes. |
|
@linfangrong We will try to make the redis.io website update the stars automatically from the GitHub API. I don't think we want to merge only whitespace fixes. |
zuiderkwast
changed the title
|
As @zuiderkwast said, stars are no longer needed here. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format