feat(sentinel): add sSubscribe/sUnsubscribe methods to Sentinel client#3178
Open
nkaradzhov wants to merge 1 commit intoredis:masterfrom
Open
feat(sentinel): add sSubscribe/sUnsubscribe methods to Sentinel client#3178nkaradzhov wants to merge 1 commit intoredis:masterfrom
nkaradzhov wants to merge 1 commit intoredis:masterfrom
Conversation
Add sharded pub/sub methods (sSubscribe/sUnsubscribe) to the Sentinel client for API consistency with the standalone Redis client. Since Sentinel manages a single master with no sharding, these methods provide no sharding benefit - they simply pass through to the underlying Redis commands. This enables compatibility with libraries like @socket.io/redis-adapter that expect the sSubscribe method to be available. fixes redis#3177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sharded pub/sub methods (sSubscribe/sUnsubscribe) to the Sentinel client for API consistency with the standalone Redis client. Since Sentinel manages a single master with no sharding, these methods provide no sharding benefit - they simply pass through to the underlying Redis commands. This enables compatibility with libraries like @socket.io/redis-adapter that expect the sSubscribe method to be available.
fixes #3177
Description
Checklist
npm testpass with this change (including linting)?