pubsub error handling

[17neverends]

hi! I noticed strange error ignore in pubsub section. i think we need to change method signature for (*PubSub, error) for move error on top call stack

[jit-ci]

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

[ndyakov]

Good catch @17neverends , sadly we cannot change the signature right now (it will be a breaking change). We should track this and address it in v10. If you would like, you can open an issue and ping me to triage it.

p.s. feel free to fix the build and we can review / approve / merge the pr.

[17neverends]

Good catch @17neverends , sadly we cannot change the signature right now (it will be a breaking change). We should track this and address it in v10. If you would like, you can open an issue and ping me to triage it.

p.s. feel free to fix the build and we can review / approve / merge the pr.

ok, thank for feedback! i didn't understand what it meant "fix the build"... you mean failed benchmarks?

[ndyakov]

Yes, by "the build," I’m referring to the workflows defined in the repository.