Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one errors in rate limiting samples. #613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix off-by-one errors in rate limiting samples. #613

wants to merge 2 commits into from

Commits on Sep 4, 2023

  1. Fix off-by-one error in fixed-window rate limiting sample 

    Code increments number of requests, then checks if result is less than max allowed requests. This causes the last request to be denied incorrectly. The text also describes the correct operator as less than or equal to.
    @kimsey0
    kimsey0 authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    ad1c3a8 View commit details
    Browse the repository at this point in the history

  2. Fix off-by-one error in sliding-window rate limiting sample

    @kimsey0
    kimsey0 authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    09539f8 View commit details
    Browse the repository at this point in the history