Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change versioning #48

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Change versioning #48

merged 2 commits into from
Nov 20, 2023

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Nov 14, 2023

The current versioning is considered pre-release. Switching to use a slightly different format to make every release a patch release.

The version of the patch release is now the epoch of the latest commit date merged into main

Before: 0.2.1-{%Y%m%D%H%M}git{SHA}
Now: 0.2.{%s}+{%Y%m%D%H%M}.git{SHA}

The + delimits the version from metadata for the release

NOTE: With this new version format I'm seeing 500/400 errors from galaxy when testing. Despite the errors the collection is published but this affects the state of the GHA. It has been reported in https://forum.ansible.com/t/http-500-400-errors-when-publishing-collections/2380

NOTE: Issue opened for the 500 error ansible/galaxy#3287

The current versioning is considered pre-release. Switching to use a
slightly different format to make every release a patch release.

The version of the patch release is now the epoch of the latest commit
date merged into main

Before: 0.2.1-{%Y%m%D%H%M}git{SHA}
Now: 0.2.{%s}+{%Y%m%D%H%M}.git{SHA}

The + delimits the version from metadata for the release
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/acd6bb7349284b5ba5765c672b4f361c

✔️ dci-rpm-build-el8 SUCCESS in 12m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 46s

Due to ansible/galaxy#3287 can't run the GHA
ansible/ansible-publish-action without failing, despite the error 500,
the collection is published, we are ignoring the 500 until fixed.
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/7be97dc35625432b9d5cd4c7c5175f32

✔️ dci-rpm-build-el8 SUCCESS in 11m 16s
✔️ dci-rpm-build-el9 SUCCESS in 2m 57s

@tonyskapunk tonyskapunk marked this pull request as ready for review November 16, 2023 19:43
Copy link
Contributor

@thekad thekad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tonyskapunk tonyskapunk merged commit 9239258 into main Nov 20, 2023
1 check passed
@tonyskapunk tonyskapunk deleted the continuous_release_versioning branch November 20, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants