Update assembly-pantheon-help.adoc #504
Conversation
be consistent in the use of modules (and help support use of https://chrome.google.com/webstore/detail/asciidoctorjs-live-previe/iaalpfgpbocpdfblpnhhgllgbdbchmia)
|
If this PR is merged, you can view the whole guide (using the chrome extension above) at https://raw.githubusercontent.com/pwright/pantheon/patch-1/pantheon-bundle/src/main/resources/SLING-INF/content/docs/assemblies/assembly-pantheon-help.adoc |
|
Hey @pwright Thanks for the contribution! If I understand correctly, the goal in this PR is to enable previewing the Pantheon 2 documentation using a Google Chrome extension. I'm guessing that the extension doesn't support the use of symlinks in file paths, which would explain why you changed the include file path. Is that correct? So first of all, be aware that because of Pantheon 2's current lack of support for nested assemblies, we are about to merge (PR 533)[https://github.com//pull/533] which will severely impact this PR (504). You might want to take a look at that one. Secondly, it would be helpful (if you decide to update this PR after we merge 533) to include some text describing asciidoctorjs-live-preview and where to find info on installing and using it. I think that might actually make the most sense to appear in the README. Thirdly, be aware that the EUD is slated to be released and viewable from within Pantheon in the next release of Pantheon, which I am given to understand will be within a few weeks. Once it is viewable from within Pantheon, do you still see benefit to this PR? |
|
My reading of the related PR (533) is that we're going 'All in' wrt symlinks. viewable in pantheon requires vpn access, and will only show latest published version. This PR would allow viewing of all branches, versions, forks, etc (that's the point of it) |
|
@stoobie you're correct, closing |
be consistent in the use of modules (and help support use of https://chrome.google.com/webstore/detail/asciidoctorjs-live-previe/iaalpfgpbocpdfblpnhhgllgbdbchmia)