(RHEL-18302) Avoid memory allocation in freeze() #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracker - RHEL-18302 The following commits meet all requirements
|
github-actions
bot
added
pr/needs-ci
(cherry picked from commit 498e265) Related: RHEL-18302
msekletar
force-pushed
the
rhel-18302
branch
from
ce0a150
to
44f49aa
Compare
I had a test machine with ulimit -n set to 1073741816 through pam
("session required pam_limits.so set_all", which copies the limits from PID 1,
left over from testing of #10921).
test-execute would "hang" and then fail with a timeout when running
exec-inaccessiblepaths-proc.service. It turns out that the problem was in
close_all_fds(), which would go to the fallback path of doing close()
1073741813 times. Let's just fail if we hit this case. This only matters
for cases where both /proc is inaccessible, and the *soft* limit has been
raised.
(gdb) bt
#0 0x00007f7e2e73fdc8 in close () from target:/lib64/libc.so.6
redhat-plumbers#1 0x00007f7e2e42cdfd in close_nointr ()
from target:/home/zbyszek/src/systemd-work3/build-rawhide/src/shared/libsystemd-shared-241.so
redhat-plumbers#2 0x00007f7e2e42d525 in close_all_fds ()
from target:/home/zbyszek/src/systemd-work3/build-rawhide/src/shared/libsystemd-shared-241.so
redhat-plumbers#3 0x0000000000426e53 in exec_child ()
redhat-plumbers#4 0x0000000000429578 in exec_spawn ()
redhat-plumbers#5 0x00000000004ce1ab in service_spawn ()
redhat-plumbers#6 0x00000000004cff77 in service_enter_start ()
redhat-plumbers#7 0x00000000004d028f in service_enter_start_pre ()
redhat-plumbers#8 0x00000000004d16f2 in service_start ()
redhat-plumbers#9 0x00000000004568f4 in unit_start ()
redhat-plumbers#10 0x0000000000416987 in test ()
redhat-plumbers#11 0x0000000000417632 in test_exec_inaccessiblepaths ()
redhat-plumbers#12 0x0000000000419362 in run_tests ()
redhat-plumbers#13 0x0000000000419632 in main ()
(cherry picked from commit 6a461d1)
Related: RHEL-18302
…l_fds_without_malloc() (cherry picked from commit 1196655) Related: RHEL-18302
(cherry picked from commit ab27b2f) Resolves: RHEL-18302
msekletar
force-pushed
the
rhel-18302
branch
from
44f49aa
to
d8c98a3
Compare
github-actions
bot
added
tracker/missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.