Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RHEL-5863) service: schedule cleanup of PID hashmaps when we now longer have mai… #418

Merged
merged 1 commit into from
Feb 12, 2024
Merged

(RHEL-5863) service: schedule cleanup of PID hashmaps when we now longer have mai… #418

merged 1 commit into from
Feb 12, 2024

Conversation

msekletar
Copy link
Member

@msekletar msekletar commented Dec 12, 2023 •
edited by jamacku
Loading

…n_pid and we are in container

RHEL-only

Resolves: RHEL-5863

@msekletar
service: schedule cleanup of PID hashmaps when we now longer have mai…
f461dc6 
…n_pid and we are in container

RHEL-only

Resolves: RHEL-5863
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Commit validation

Tracker - RHEL-5863

The following commits meet all requirements

commit upstream
f461dc6 - service: schedule cleanup of PID hashmaps when we now longer have main… RHEL-only

Tracker validation

Success

🟢 Tracker RHEL-5863 has set desired product: rhel-8.2.0
🟢 Tracker RHEL-5863 has set desired component: systemd
🟢 Tracker RHEL-5863 has been approved

Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@github-actions github-actions bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review tracker/unapproved Formerly needs-acks labels Dec 12, 2023
@mrc0mmand
Copy link
Member

(The C8S fail is unrelated, working on a workaround, will restart the job once it's ready.)

@github-actions github-actions bot removed the pr/needs-ci Formerly needs-ci label Dec 12, 2023
@msekletar
Copy link
Member Author

It is not clear at this point whether we end up using this proposed fix or not but I'd appreciate early look from @dtardon. Please let me know what do you think.

@github-actions GitHub Actions

This comment was marked as duplicate.

Sign in to view
@github-actions github-actions bot added tracker/missing Formerly needs-bz and removed tracker/missing Formerly needs-bz labels Jan 16, 2024
@jamacku jamacku requested a review from dtardon January 17, 2024 18:57
@msekletar
Copy link
Member Author

Customer confirmed that issue is indeed fix by this cgroup v1 workaround. @dtardon I'd appreciate if you could take a look and give it yay or nay.

@jamacku jamacku added this to the RHEL-8.10 milestone Jan 21, 2024
@github-actions github-actions bot removed the tracker/unapproved Formerly needs-acks label Feb 9, 2024
dtardon
dtardon approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Feb 12, 2024
@github-actions github-actions bot merged commit 8bf7a6f into redhat-plumbers:main Feb 12, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtardon dtardon dtardon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
RHEL-8.10
Development

Successfully merging this pull request may close these issues.
4 participants
@msekletar @mrc0mmand @dtardon @jamacku