(RHEL-1087) test: backport TEST-81-GENERATORS (fstab-generator only) #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracker - RHEL-1087 The following commits meet all requirements
|
github-actions
bot
added
pr/needs-ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
shellcheck found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Based on: ed4ad48 Related: RHEL-1087 rhel-only
Based on: 99e3d4767932bce5febb45e8543162d729d17425 Related: RHEL-1087 rhel-only
mrc0mmand
force-pushed
the
generator-tests
branch
2 times, most recently
from
211bbd6
to
b0309a0
Compare
github-actions
bot
changed the title
mrc0mmand
force-pushed
the
generator-tests
branch
from
b0309a0
to
3a77b20
Compare
Some fstab-generator features are not present on RHEL 8 or they behave differently - in such case there's an inline comment explaining what's different with a reference to an upstream commit that introduced the changed behavior. Related: RHEL-1087 rhel-only
mrc0mmand
force-pushed
the
generator-tests
branch
from
3a77b20
to
9e50ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fstab-generator features are not present on RHEL 8 or they behave
differently - in such case there's an inline comment explaining what's
different with a reference to an upstream commit that introduced the
changed behavior.
Realated: https://issues.redhat.com/browse/RHEL-1087
rhel-only
Given the recent issue regarding fstab-generator, let's backport the fstab-genreator part of TEST-81-GENERATORS from upstream to make sure we'd catch such issues in the future.