Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RHEL-2857) login: Add KEY_RESTART handling #411

Merged
merged 2 commits into from
Jan 20, 2024
Merged

(RHEL-2857) login: Add KEY_RESTART handling #411

merged 2 commits into from
Jan 20, 2024

Conversation

lnykryn
Copy link
Member

@lnykryn lnykryn commented Sep 11, 2023 •
edited by jamacku
Loading

No description provided.

poettering and others added 2 commits September 11, 2023 16:01
@poettering @lnykryn
tree-wide: always declare bitflag enums the same way
fea141e 
let's always use the 1 << x syntax. No change of behaviour or even of
the compiled binary.

(cherry picked from commit be0b7a1)

Resolves: RHEL-2857
@robimarko @lnykryn
login: Add KEY_RESTART handling
5c8a725 
KEY_RESTART is widely used in Linux to indicate device reboot.
So lets handle it in the same fashion as KEY_POWER.

Signed-off-by: Robert Marko <[email protected]>
(cherry picked from commit adbb2b6)

Resolves: RHEL-2857
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Sep 11, 2023
@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

Commit validation

Tracker - RHEL-2857

The following commits meet all requirements

commit upstream
fea141e - tree-wide: always declare bitflag enums the same way systemd/systemd@be0b7a1
5c8a725 - login: Add KEY_RESTART handling systemd/systemd@adbb2b6

Tracker validation

Success

🟢 Tracker RHEL-2857 has set desired product: CentOS Stream 8
🟢 Tracker RHEL-2857 has set desired component: systemd
🟢 Tracker RHEL-2857 has been approved

Pull Request validation

Success

🟡 CI - Waived
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

Auto Merge

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟢 Pull Request meet requirements, mergeable is true
🟠 Pull Request meet requirements, mergeable_state is unstable
🟢 Pull Request has correct target branch main
🟢 Pull Request was merged

@lnykryn lnykryn changed the title Rhel 2857 login: Add KEY_RESTART handling Sep 11, 2023
@systemd-rhel-bot systemd-rhel-bot added pr/needs-review Formerly needs-review tracker/missing Formerly needs-bz labels Sep 11, 2023
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Sep 11, 2023
@jamacku jamacku changed the title login: Add KEY_RESTART handling (RHEL-2857) login: Add KEY_RESTART handling Sep 14, 2023
@github-actions github-actions bot changed the title (RHEL-2857) login: Add KEY_RESTART handling (RHEL-2857) (RHEL-2857) login: Add KEY_RESTART handling Sep 19, 2023
@jamacku jamacku changed the title (RHEL-2857) (RHEL-2857) login: Add KEY_RESTART handling (RHEL-2857) login: Add KEY_RESTART handling Sep 19, 2023
@github-actions github-actions bot changed the title (RHEL-2857) login: Add KEY_RESTART handling (RHEL-2857) (RHEL-2857) login: Add KEY_RESTART handling Sep 19, 2023
@jamacku jamacku changed the title (RHEL-2857) (RHEL-2857) login: Add KEY_RESTART handling (RHEL-2857) login: Add KEY_RESTART handling Sep 19, 2023
@github-actions github-actions bot added tracker/unapproved Formerly needs-acks and removed tracker/missing Formerly needs-bz labels Sep 20, 2023
@github-actions github-actions bot added the pr/needs-ci Formerly needs-ci label Oct 20, 2023
@jamacku jamacku requested a review from dtardon October 20, 2023 11:48
@github-actions github-actions bot removed tracker/unapproved Formerly needs-acks pr/needs-ci Formerly needs-ci labels Oct 20, 2023
@github-actions github-actions bot added tracker/missing Formerly needs-bz and removed tracker/missing Formerly needs-bz labels Dec 2, 2023
@github-actions github-actions bot removed the tracker/missing Formerly needs-bz label Dec 9, 2023
@github-actions github-actions bot added tracker/missing Formerly needs-bz and removed tracker/missing Formerly needs-bz labels Dec 23, 2023
@jamacku jamacku added this to the RHEL-8.10 milestone Jan 8, 2024
@github-actions GitHub Actions

This comment was marked as duplicate.

Sign in to view
msekletar
msekletar approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the pr/needs-review Formerly needs-review label Jan 20, 2024
@github-actions github-actions bot merged commit d3072ce into redhat-plumbers:main Jan 20, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msekletar msekletar msekletar approved these changes

@dtardon dtardon Awaiting requested review from dtardon

Assignees
No one assigned
Labels
ci-waived released
Projects
None yet
Milestone
RHEL-8.10
Development

Successfully merging this pull request may close these issues.
6 participants
@lnykryn @msekletar @jamacku @systemd-rhel-bot @poettering @robimarko