Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2179309) doc: add downstream CONTRIBUTING document #407

Merged
merged 1 commit into from
Aug 8, 2023
Merged

(#2179309) doc: add downstream CONTRIBUTING document #407

merged 1 commit into from
Aug 8, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Aug 4, 2023 •
edited by github-actions bot
Loading

rhel-only

Related: #2179309

@jamacku jamacku added this to the RHEL-8.9 milestone Aug 4, 2023
@jamacku jamacku requested a review from lnykryn August 4, 2023 11:11
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited
Loading

Tracker - 2179309

The following commits meet all requirements

commit upstream
47530e2 - doc: add downstream CONTRIBUTING document rhel-only

@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Aug 4, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title doc: add downstream CONTRIBUTING document (#2179309) doc: add downstream CONTRIBUTING document Aug 4, 2023
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Aug 4, 2023
dtardon
dtardon reviewed Aug 7, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
dtardon
dtardon reviewed Aug 7, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Aug 7, 2023
@jamacku jamacku requested a review from dtardon August 7, 2023 14:08
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Aug 7, 2023
@systemd-rhel-bot systemd-rhel-bot added tracker/missing Formerly needs-bz and removed tracker/missing Formerly needs-bz labels Aug 8, 2023
dtardon
dtardon reviewed Aug 8, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jamacku
doc: add downstream CONTRIBUTING document
47530e2 
rhel-only

Related: #2179309
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Aug 8, 2023
dtardon
dtardon approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Aug 8, 2023
jamacku added a commit to jamacku/systemd-rhel9 that referenced this pull request Aug 8, 2023
@jamacku
doc: improve CONTRIBUTING document
0dab677 
based on feedback from: redhat-plumbers/systemd-rhel8#407

rhel-only

Related: #2170883
@jamacku jamacku mentioned this pull request Aug 8, 2023
Merged
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Aug 8, 2023
@systemd-rhel-bot systemd-rhel-bot merged commit 322ef6c into redhat-plumbers:main Aug 8, 2023
8 checks passed
systemd-rhel-bot pushed a commit to redhat-plumbers/systemd-rhel9 that referenced this pull request Aug 8, 2023
@jamacku @systemd-rhel-bot
doc: improve CONTRIBUTING document
2c849b9 
based on feedback from: redhat-plumbers/systemd-rhel8#407

rhel-only

Related: #2170883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtardon dtardon dtardon approved these changes

@lnykryn lnykryn Awaiting requested review from lnykryn

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
RHEL-8.9
Development

Successfully merging this pull request may close these issues.
3 participants
@jamacku @dtardon @systemd-rhel-bot