Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2223602) Better handle session leader information #405

Merged
merged 2 commits into from
Jul 20, 2023
Merged

(#2223602) Better handle session leader information #405

merged 2 commits into from
Jul 20, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Jul 20, 2023 •
edited by github-actions bot
Loading

No description provided.

yuwata and others added 2 commits July 20, 2023 13:06
@yuwata @jamacku
login: add a missing error check for session_set_leader()
b16b623 
session_set_leader() may fail. If it fails, then manager_start_scope()
will trigger assertion.

This may be related to RHBZ#1663704.

(cherry picked from commit fe3ab84)

Related: #2223602
@msekletar @jamacku
logind: reset session leader if we know for a fact that it is gone
2797f94 
rhel-only

Related: #2223602
@jamacku jamacku requested a review from msekletar July 20, 2023 11:09
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Jul 20, 2023
@github-actions
Copy link

Tracker - 2223602

The following commits meet all requirements

commit upstream
b16b623 - login: add a missing error check for session_set_leader() systemd/systemd@fe3ab84
2797f94 - logind: reset session leader if we know for a fact that it is gone rhel-only

@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Jul 20, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title Better handle session leader information (#2223602) Better handle session leader information Jul 20, 2023
msekletar
msekletar approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Jul 20, 2023
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Jul 20, 2023
@jamacku jamacku merged commit 33c6637 into redhat-plumbers:rhel-8.8.0 Jul 20, 2023
10 checks passed
@jamacku jamacku deleted the bz2223602-logind-assertion branch July 20, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msekletar msekletar msekletar approved these changes

Assignees
No one assigned
Labels
released rhel-8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamacku @msekletar @systemd-rhel-bot @yuwata