Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2217786) Enable pstore by default #400

Merged

Conversation

dtardon
Copy link
Member

@dtardon dtardon commented Jun 29, 2023

Resolves: #2217786

(cherry picked from commit e3b1926)

Related: #2217786
That is the pattern that we always use with executables not in
$PATH.

(cherry picked from commit aa07dc7)

Related: #2217786
It has no effect is the pstore is not used, and prevents the non-volatile
storage from filling up if is used by the kernel.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=952767
(cherry picked from commit 5926ea0)

Resolves: #2217786
@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label Jun 29, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title Enable pstore by default (#2217786) Enable pstore by default Jun 29, 2023
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label Jun 29, 2023
@systemd-rhel-bot systemd-rhel-bot added the tracker/unapproved Formerly needs-acks label Jun 29, 2023
@github-actions
Copy link

Tracker - 2217786

The following commits meet all requirements

commit upstream
4b8e59b - man: tweak markup in systemd-pstore.service(8) systemd/systemd@e3b1926
systemd/systemd-stable@e3b1926
8f8a34f - man: add .service suffix to systemd-pstore(8) systemd/systemd@aa07dc7
systemd/systemd-stable@aa07dc7
41fab18 - presets: enable systemd-pstore.service by default systemd/systemd@5926ea0
systemd/systemd-stable@5926ea0

@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label Jun 29, 2023
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed pr/needs-review Formerly needs-review tracker/unapproved Formerly needs-acks labels Jul 12, 2023
@systemd-rhel-bot systemd-rhel-bot merged commit 36d9a1a into redhat-plumbers:main Jul 13, 2023
10 checks passed
@dtardon dtardon deleted the bz2217786-pstore-preset branch July 13, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants