Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#2156786) Add idle time column to loginctl list-sessions #393

Merged
merged 6 commits into from
Jul 13, 2023
Merged

(#2156786) Add idle time column to loginctl list-sessions #393

merged 6 commits into from
Jul 13, 2023

Conversation

dtardon
Copy link
Member

@dtardon dtardon commented May 30, 2023 •
edited by github-actions bot
Loading

Resolves: #2156786

yuwata and others added 6 commits May 30, 2023 15:16
@yuwata @dtardon
format-table: add TABLE_TIMESTAMP_UTC and _RELATIVE
a50c280 
(cherry picked from commit c5bbb2b)

Related: #2156786
@dtardon
loginctl: shorten variable name
19e1625 
(cherry picked from commit 86f128558d57586bd28c55eb63968eab3dc4b36e)

Related: #2156786
@dtardon
loginctl: use bus_map_all_properties
276a13c 
(cherry picked from commit 5b7d1536d0c2ccf0b7688490f31c92c1e766ea44)

Related: #2156786
@dtardon
loginctl: show session idle status in list-sessions
a002b4c 
(cherry picked from commit 556723e738b96a5c2b2d45a96b87b7b80e0c5664)

Resolves: #2156786
@YHNdnzj @dtardon
loginctl: list-sessions: fix timestamp for idle hint
774cb4a 
Follow-up for 556723e738b96a5c2b2d45a96b87b7b80e0c5664

TABLE_TIMESTAMP_RELATIVE takes a realtime timestamp.

(cherry picked from commit be88af3d9646c8bd1aaea3d4a00520e97ee8674d)

Related: #2156786
@YHNdnzj @dtardon
loginctl: also show idle hint in session-status
9f3b1ba 
(cherry picked from commit 82449055af97cf92466dbe132a89c9d889440c3d)

Related: #2156786
@mergify mergify bot added the pr/needs-ci Formerly needs-ci label May 30, 2023
@github-actions
Copy link

Tracker - 2156786

The following commits meet all requirements

commit upstream
a50c280 - _format-table: add TABLE_TIMESTAMP_UTC and RELATIVE systemd/systemd@c5bbb2b
systemd/systemd-stable@c5bbb2b
19e1625 - loginctl: shorten variable name systemd/systemd@86f1285
systemd/systemd-stable@86f1285
276a13c - loginctl: use bus_map_all_properties systemd/systemd@5b7d153
systemd/systemd-stable@5b7d153
a002b4c - loginctl: show session idle status in list-sessions systemd/systemd@556723e
systemd/systemd-stable@556723e
774cb4a - loginctl: list-sessions: fix timestamp for idle hint systemd/systemd@be88af3
systemd/systemd-stable@be88af3
9f3b1ba - loginctl: also show idle hint in session-status systemd/systemd@8244905
systemd/systemd-stable@8244905

@systemd-rhel-bot systemd-rhel-bot added the pr/needs-review Formerly needs-review label May 30, 2023
@systemd-rhel-bot systemd-rhel-bot changed the title Add idle time column to loginctl list-sessions (#2156786) Add idle time column to loginctl list-sessions May 30, 2023
@systemd-rhel-bot systemd-rhel-bot added the tracker/unapproved Formerly needs-acks label May 30, 2023
@mergify mergify bot removed the pr/needs-ci Formerly needs-ci label May 30, 2023
msekletar
msekletar approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Jun 14, 2023
@systemd-rhel-bot systemd-rhel-bot removed the tracker/unapproved Formerly needs-acks label Jul 13, 2023
@systemd-rhel-bot systemd-rhel-bot merged commit 0d3f481 into redhat-plumbers:main Jul 13, 2023
@dtardon dtardon deleted the bz2156786-list-sessions-idle branch July 13, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msekletar msekletar msekletar approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dtardon @msekletar @jamacku @systemd-rhel-bot @yuwata @YHNdnzj