Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qeth_rules): check the existence of /sys/devices/qeth/*/online beforehand #36

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Jan 15, 2024

On s390x KVM machines, the follow errors occurred,
$ kdumpctl rebuild
kdump: Rebuilding /boot/initramfs-4.18.0-321.el8.s390xkdump.img
/usr/lib/dracut/modules.d/95qeth_rules/module-setup.sh: line 13: /sys/devices/qeth//online: No such file or directory
/usr/lib/dracut/modules.d/95qeth_rules/module-setup.sh: line 13: /sys/devices/qeth/
/online: No such file or directory

because s390x KVM uses virtual devices and /sys/devices/qeth/*/online
doesn't exist. Eliminate this error by checking the existence
beforehand.

(Cherry-picked commit: 04fd4f0139c25e6f3846e759de15ac80ec807887)

Resolves: RHEL-17239

…forehand

On s390x KVM machines, the follow errors occurred,
    $ kdumpctl rebuild
    kdump: Rebuilding /boot/initramfs-4.18.0-321.el8.s390xkdump.img
    /usr/lib/dracut/modules.d/95qeth_rules/module-setup.sh: line 13: /sys/devices/qeth/*/online: No such file or directory
    /usr/lib/dracut/modules.d/95qeth_rules/module-setup.sh: line 13: /sys/devices/qeth/*/online: No such file or directory

because s390x KVM uses virtual devices and /sys/devices/qeth/*/online
doesn't exist. Eliminate this error by checking the existence
beforehand.

(Cherry-picked commit: 04fd4f0139c25e6f3846e759de15ac80ec807887)

Resolves: RHEL-17239
@pvalena pvalena added the bug Something isn't working label Jan 15, 2024
@pvalena pvalena self-assigned this Jan 15, 2024
@pvalena pvalena marked this pull request as ready for review January 15, 2024 08:24
@pvalena
Copy link
Contributor Author

pvalena commented Jan 15, 2024

LGTM.

@pvalena pvalena merged commit 141a2ec into redhat-plumbers:main Jan 15, 2024
13 checks passed
@pvalena pvalena deleted the rhel-8-fix-17239 branch January 15, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants