Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype #24

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Prototype #24

merged 7 commits into from
Oct 24, 2023

Conversation

jamartis
Copy link
Contributor

Basic prototype: known issues:

  • config command is not yet implemented
  • most of "common options" are not implemented
  • the DB file/drop in folder are hardcoded to /tmp/alts.yml and /tmp/dropins respectively
  • the files/folder from the prev. point must already exist
  • the symlinks are not yet created on the disk, only printed out to the stdout
  • the proper relation of the name -> link -> path symlinks has to be checked
  • general code cleanup + return types (pretty sure some could be switched to a referneces instead of clones)
  • I might have overwritten some of the .toml files/tests from the previous commits. Sorry for that:-/

@jamartis
Add: conversion of --install command to yaml file
9f7e307
@jamartis
Add: --display command now parses the content of the DB file
a02a024
@jamartis
WIP: update the install/display commands, add some basic support for …
217e7d3 
…dropins

install: install should now append new alternatives to an existing
	 if the alternative group already exists in the builtin
         directory, otherwise it creates a new alternative group
display: should now print all alternative groups (the filtering based on
	 the name is not implemented yet) both in builtins config file
	 and in the dropins subdirecotry
@jamartis
Add: filtering for the display command
52a945b
@jamartis
Code cleanup
6ee5703
@jamartis
add: the implementation of the auto command (also called at the end o…
f57ea98 
…f the install command) [WIP]
@jamartis
Add: auto and set commands
9b7f866
@jamacku jamacku changed the base branch from main to prototype October 24, 2023 13:05
@jamacku jamacku changed the title Prototype [WIP] Prototype Oct 24, 2023
jamacku
jamacku approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamacku jamacku merged commit c34f4d0 into redhat-plumbers:prototype Oct 24, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamacku jamacku jamacku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamartis @jamacku