test: csdiff#170
#371
Closed
test: csdiff#170
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamacku
commented
Apr 17, 2024
jamacku
commented
- writer-sarif: add descriptions for ShellCheck rules csutils/csdiff#170
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -4,13 +4,13 @@ | |||
| # Quoting | |||
| # ======= | |||
|
|
|||
| # echo $1 # Unquoted variables | |||
| echo $1 # Unquoted variables | |||
Check warning
Code scanning / shellcheck
SC2086 Warning documentation
| # rm "~/my file.txt" # Quoted tilde expansion | ||
| # v='--verbose="true"'; cmd $v # Literal quotes in variables | ||
| # touch $@ # Unquoted $@ | ||
| # echo 'Path is $PATH' # Variables in single quotes | ||
| touch $@ # Unquoted $@ |
Check failure
Code scanning / shellcheck
SC2068 Error documentation
| # touch $@ # Unquoted $@ | ||
| # echo 'Path is $PATH' # Variables in single quotes | ||
| touch $@ # Unquoted $@ | ||
| echo 'Path is $PATH' # Variables in single quotes |
Check warning
Code scanning / shellcheck
SC2016 Warning documentation
| # trap "echo Took ${SECONDS}s" 0 # Prematurely expanded trap | ||
| # unset var[i] # Array index treated as glob | ||
| unset var[i] # Array index treated as glob |
Check warning
Code scanning / shellcheck
SC2184 Warning documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.