-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for scaleout with composable roles #529
Conversation
hostname: "{{ undercloud_hostname }}" | ||
user: "stack" | ||
|
||
- name: add undercloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If cleanup.yml
has not been run after overcloud deployment, won't the undercloud still be present in the inventory from the previous deployment? In that case, it wouldn't have to be added to the inventory again.
Although, if a deployment on another allocation has been run before the scaleout, then this step would be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scaleout.yml is independent of what allocation has been deployed before.
It can be run on any allocation that is jetpack deployed. So its good to assume that inventory is absent.
Also I have made a change to pass "undercloud_host" via group_vars/all.yml, as undercloud host need not always be the first node in lab generated instackenv.json
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
with --limit option passed to overcloud deploy command for scaleout, deployment will only be limited to hosts that are mentioned(or being scaled out).
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
These roles are needed for computes to communicate with ceph monitors.
0e480ff
to
c2324cf
Compare
include_tasks: tasks/set_root_hints.yml | ||
when: lab_name in ['scale', 'alias'] | ||
|
||
- name: create flavors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: check is it possible to use this https://docs.ansible.com/archive/ansible/2.5/modules/os_nova_flavor_module.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds support for scaleout feature with and without composable roles.