Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for virtual uc on first node #175

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

asyedham
Copy link
Member

@asyedham asyedham commented Apr 3, 2020

fixes
#173
#174

@@ -49,10 +49,33 @@
- name: set undercloud hostname
set_fact:
undercloud_hostname: "{{ undercloud_host }}"
instack_firstnode: "{{ (instackenv_content.nodes[0].pm_addr | replace('mgmt-','') | replace('-drac', '')) }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to give support for other labs also, since our CI is not running on these labs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to give support for other labs also, since our CI is not running on these labs

@masco can you please share the instackenv for those machines . I will add a task for it

@asyedham
Copy link
Member Author

asyedham commented May 7, 2020

@masco have added the option to specify the virtual undercloud. Could you please review

@@ -115,6 +115,7 @@ force_reprovision: false
#This enables user to have a undercloud in VM
#NOTE: now the vm is created in the ansible host, so
#do not enable this while running from your desktop
virtual_uc_hostname: redhat.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the above comment is for the below variable, so move this to one line below

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and make this variable optional, if users using scale or aliase lab, we no need to force the user to set this one.

@asyedham
Copy link
Member Author

@masco Could you please have look. If this needs any further changes as I'm testing it

- name: Clean network interfaces
shell: |
/root/clean-interfaces.sh --nuke
changed_when: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it throw error if clean-interfaces.sh not present on the hypervisor, for example, CI machine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

@stale
Copy link

stale bot commented Jun 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the not_ready label Jun 17, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the not_ready label Jul 18, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the not_ready label Aug 22, 2020
@stale
Copy link

stale bot commented Sep 26, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the not_ready label Sep 26, 2020
@asyedham asyedham added hold and removed not_ready labels Oct 3, 2020
@stale
Copy link

stale bot commented Nov 2, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the not_ready label Nov 2, 2020
@asyedham asyedham removed the not_ready label Nov 3, 2020
@stale
Copy link

stale bot commented Dec 3, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the not_ready label Dec 3, 2020
@asyedham asyedham removed the not_ready label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants