-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for virtual uc on first node #175
base: master
Are you sure you want to change the base?
Conversation
@@ -49,10 +49,33 @@ | |||
- name: set undercloud hostname | |||
set_fact: | |||
undercloud_hostname: "{{ undercloud_host }}" | |||
instack_firstnode: "{{ (instackenv_content.nodes[0].pm_addr | replace('mgmt-','') | replace('-drac', '')) }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to give support for other labs also, since our CI is not running on these labs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to give support for other labs also, since our CI is not running on these labs
@masco can you please share the instackenv for those machines . I will add a task for it
@masco have added the option to specify the virtual undercloud. Could you please review |
group_vars/all.yml
Outdated
@@ -115,6 +115,7 @@ force_reprovision: false | |||
#This enables user to have a undercloud in VM | |||
#NOTE: now the vm is created in the ansible host, so | |||
#do not enable this while running from your desktop | |||
virtual_uc_hostname: redhat.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the above comment is for the below variable, so move this to one line below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and make this variable optional, if users using scale or aliase lab, we no need to force the user to set this one.
@masco Could you please have look. If this needs any further changes as I'm testing it |
- name: Clean network interfaces | ||
shell: | | ||
/root/clean-interfaces.sh --nuke | ||
changed_when: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it throw error if clean-interfaces.sh not present on the hypervisor, for example, CI machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
fixes
#173
#174