Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix: Filter healthcheck #931

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Nov 17, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Since the node-healthcheck-operator and self-node-remediation operators exist in all namespaces (by design), they need to be filtered out when fetching CSV versions, but only after upgrading.

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the bug Something isn't working label Nov 17, 2024
@ebattat ebattat self-assigned this Nov 17, 2024
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example showing that the CSV exists in all namespaces?

@ebattat
Copy link
Collaborator Author

ebattat commented Nov 17, 2024

Here is an example:

[root@cnv-intel-15 ~]# oc get csv
NAME                               DISPLAY                          VERSION   REPLACES                           PHASE
node-healthcheck-operator.v0.8.2   Node Health Check Operator       0.8.2     node-healthcheck-operator.v0.8.1   Succeeded
self-node-remediation.v0.9.0       Self Node Remediation Operator   0.9.0     self-node-remediation.v0.8.0       Succeeded

[root@cnv-intel-15 ~]# oc get csv -n openshift-local-storage
NAME                                          DISPLAY                          VERSION               REPLACES                                      PHASE
local-storage-operator.v4.15.0-202411060036   Local Storage                    4.15.0-202411060036   local-storage-operator.v4.14.0-202410182001   Succeeded
node-healthcheck-operator.v0.8.2              Node Health Check Operator       0.8.2                 node-healthcheck-operator.v0.8.1              Succeeded
self-node-remediation.v0.9.0                  Self Node Remediation Operator   0.9.0                 self-node-remediation.v0.8.0                  Succeeded

[root@cnv-intel-15 ~]# oc get csv -n openshift-workload-availability
NAME                               DISPLAY                          VERSION   REPLACES                           PHASE
node-healthcheck-operator.v0.8.2   Node Health Check Operator       0.8.2     node-healthcheck-operator.v0.8.1   Succeeded
self-node-remediation.v0.9.0       Self Node Remediation Operator   0.9.0     self-node-remediation.v0.8.0       Succeeded

@ebattat
Copy link
Collaborator Author

ebattat commented Nov 20, 2024

@RobertKrawitz, any more comments ?

@ebattat ebattat merged commit 8e44a8c into redhat-performance:main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants