Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until the nodes are ready #924

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

ebattat
Copy link
Collaborator

@ebattat ebattat commented Nov 3, 2024

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

Currently, there is only node verification without waiting for it to reach the ready status.
Adding a wait for the node to be ready until timeout.

For security reasons, all pull requests need to be approved first before running any automated CI

@ebattat ebattat added the enhancement New feature or request label Nov 3, 2024
@ebattat ebattat self-assigned this Nov 3, 2024
@ebattat ebattat added the ok-to-test PR ok to test label Nov 3, 2024
Copy link
Member

@RobertKrawitz RobertKrawitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

benchmark_runner/common/oc/oc.py Outdated Show resolved Hide resolved
benchmark_runner/common/oc/oc.py Outdated Show resolved Hide resolved
@ebattat ebattat force-pushed the wait_node_ready branch 3 times, most recently from 379f5bd to c50aa26 Compare November 4, 2024 08:40
@ebattat ebattat merged commit 51f7ccf into redhat-performance:main Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ok-to-test PR ok to test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants