Integration with krkn-hub #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, currently I didnt use it but its a place holder for the future |
Could you add a comment to it to that effect, then? |
RobertKrawitz
requested changes
Oct 29, 2024
ebattat
force-pushed
the
krkn_integration
branch
from
955f036 to
4d6531c
Compare
|
You right, added a Base class for all KrknHub error classes |
RobertKrawitz
approved these changes
Oct 29, 2024
ebattat
force-pushed
the
krkn_integration
branch
from
4d6531c to
4b8ee41
Compare
ebattat
force-pushed
the
krkn_integration
branch
from
4b8ee41 to
5163af0
Compare
ebattat
force-pushed
the
krkn_integration
branch
from
5163af0 to
28633af
Compare
RobertKrawitz
approved these changes
Oct 30, 2024
ebattat
force-pushed
the
krkn_integration
branch
from
28633af to
7478b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Note: Fill x in []
Description
krkn-hub integration setup:
'krknhub_workload' e.g. node-scenarios
For more scenarios, see the documentation
'krknhub_environment_variable' e.g.
export CLOUD_TYPE=
export BMC_USER=
export BMC_PASSWORD=
export BMC_ADDR=
export NODE_NAME=
export ENABLE_ES=
export ES_SERVER=
export ES_PORT=
export ES_METRICS_INDEX=
export ES_COLLECT_METRICS=
Save krkn-hub pod logs
For security reasons, all pull requests need to be approved first before running any automated CI