Jenkinsfile: WAIT FOR UPGRADE VERSION #910
Conversation
| @@ -264,14 +258,12 @@ END | |||
| } else { | |||
| echo "Reached maximum retry attempts for workload ${workload}. Moving to the next workload..." | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Above here, do you need to check that the sudo podman run succeeds before success = true?
There was a problem hiding this comment.
I dont think it necessary
There was a problem hiding this comment.
Why? It's a simple check, and things can go wrong.
There was a problem hiding this comment.
Its only on failure
There was a problem hiding this comment.
It looks like you're relying on something raising an excception if something goes wrong, but what if the podman run simply fails? Shouldn't that be treated as a failure?
There was a problem hiding this comment.
It is more for failure inside the container, If podman run will fail, I prefer that all the run the will fail and not continue.
There was a problem hiding this comment.
Right, but that's why you should check whether the podman run fails -- if it fails, then you fail the entire run.
ebattat
changed the title
Type of change
Note: Fill x in []
Description
Currently, the stage 'WORKLOADS Verifications' runs until the stage 'OpenShift Upgrade AND Verifications' is complete. Change it to use WAIT_FOR_UPGRADE_VERSION inside the stage 'WORKLOADS Verifications', so that it runs the Windows verification in a single job loop.
For security reasons, all pull requests need to be approved first before running any automated CI